fix(falcon/async_resource): replace the use of removed resp.body#1516
Open
vytas7 wants to merge 1 commit into
Open
fix(falcon/async_resource): replace the use of removed resp.body#1516vytas7 wants to merge 1 commit into
vytas7 wants to merge 1 commit into
Conversation
|
Thanks for the contribution! Before we can merge this, we need @vytas7 to sign the Salesforce Inc. Contributor License Agreement. |
vytas7
commented
May 30, 2026
| return | ||
|
|
||
| resp.status = "404" | ||
| # Falcon 4.x w/ mypy fails to correctly infer the str type here |
Author
There was a problem hiding this comment.
Mypy was actually functioning correctly - resp.body was removed long ago.
(All this could be replaced with a onliner raising HTTPNotFound, especially if you're OK with a JSON error.)
Author
|
(I believe I have now signed the CLA.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.